This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Slow tabs #861
Merged
Slow tabs #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwitzel3
approved these changes
Apr 22, 2020
internal/describer/object.go
Outdated
| o.tabFuncDescriptors = []Tab{ | ||
| {Name: "Summary", Factory: SummaryTab}, | ||
| {Name: "Metadata", Factory: MetadataTab}, | ||
| {Name: "Resource Viewer", Factory: ResourceViewerTab(false)}, // TODO: Fix me |
There was a problem hiding this comment.
can we create an issue for this fix me with what needs to be fixed, can leave the TODO but have it reference a GH issue.
| "github.com/vmware-tanzu/octant/pkg/view/component" | ||
| ) | ||
|
|
||
| func CustomResourceSummaryTab(crdName string) TabFactory { |
There was a problem hiding this comment.
I'd prefer to see all of these share the same signature. I'd expect them all to return a TabFactory, not some of them also directly be a TabFactory based on the naming convention. My initial thought is to make them all return a TabFactory and create a TabFactoryOptions type they can accept for the factories that need setup before we do Component generation.
A previous change removed the frontend redirect. It is required to set the current URL when navigating from root. Signed-off-by: bryanl <bryanliles@gmail.com>
This change consolidates the tab printing function for objects and custom resources. It also runs the tab generate process concurrently. Signed-off-by: bryanl <bryanliles@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change does two things:
Release note: